fix(nix): watch scripts in nix-hashes workflow#12818
Merged
rekram1-node merged 4 commits intoanomalyco:devfrom Feb 9, 2026
Merged
fix(nix): watch scripts in nix-hashes workflow#12818rekram1-node merged 4 commits intoanomalyco:devfrom
rekram1-node merged 4 commits intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the nix-hashes GitHub Actions workflow triggers so it reruns when Nix inputs that affect the node_modules derivation change, preventing stale nix/hashes.json updates.
Changes:
- Add
nix/node_modules.nixto the workflowpathstrigger. - Add
nix/scripts/**to the workflowpathstrigger so script changes also trigger hash recomputation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
106d6b0 to
2cf3779
Compare
nix/scripts/*.ts and patches/* are included in node_modules derivation. Changes to these files invalidate hashes but didn't trigger rebuild. Also removes non-existent install/ from node_modules.nix fileset. Fixes anomalyco#12817
2cf3779 to
2a99a1c
Compare
Contributor
|
LGTM |
Contributor
|
@jerome-benoit @rekram1-node actually nevermind, the desktop build needs the install script Cannot build '/nix/store/jrkk83ywjk3pvvsr46lzxc3f7x0a0gnn-opencode-desktop-1.1.53-5be1202-dirty.drv'.
Reason: builder failed with exit code 1.
Output paths:
/nix/store/bgwaaavb52cmpn76dw6qs1sijvwp4s1x-opencode-desktop-1.1.53-5be1202-dirty
Last 25 log lines:
> error: couldn't read `src/../../../../install`: No such file or directory (os error 2)
> --> src/cli.rs:56:30
> |
> 56 | const INSTALL_SCRIPT: &str = include_str!("../../../../install");
> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> warning: unused import: `process::Command`
> --> src/lib.rs:25:5
> |
> 25 | process::Command,
> | ^^^^^^^^^^^^^^^^
> |
> = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
>
> warning: unused variable: `app_name`
> --> src/lib.rs:237:20
> |
> 237 | fn check_linux_app(app_name: &str) -> bool {
> | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_app_name`
> |
> = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
>
> warning: `opencode-desktop` (lib) generated 2 warnings
> error: could not compile `opencode-desktop` (lib) due to 1 previous error; 2 warnings emitted
> Error failed to build app: failed to build app |
jerome-benoit
added a commit
to jerome-benoit/opencode
that referenced
this pull request
Feb 9, 2026
The install script was incorrectly removed in anomalyco#12818. It is required by the desktop build as cli.rs uses include_str!("../../../../install"). Fixes the regression reported in anomalyco#12818 comments.
jerome-benoit
added a commit
to jerome-benoit/opencode
that referenced
this pull request
Feb 9, 2026
The install script was incorrectly removed in anomalyco#12818. It is required by the desktop build as cli.rs uses include_str!("../../../../install"). Fixes the regression reported in anomalyco#12818 comments.
fanjia1024
pushed a commit
to fanjia1024/opencode
that referenced
this pull request
Feb 10, 2026
BryceRyan
pushed a commit
to BryceRyan/opencode
that referenced
this pull request
Feb 10, 2026
avion23
pushed a commit
to avion23/opencode
that referenced
this pull request
Feb 13, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12817
Fixes #12811
nix/scripts/*.tsandpatches/*are included in thenode_modulesderivation. Changes to these files invalidate output hashes but didn't trigger the workflow.nix/node_modules.nix,nix/scripts/**, andpatches/**to paths triggerinstall/from fileset